Importing error: fromEdges and to Edges

mrcachly · January 17, 2025, 2:52pm

I am importing the planet file and getting a strange error:

java.lang.IllegalArgumentException: fromEdges and toEdges cannot be size > 1 at the same time
        at com.graphhopper.reader.osm.RestrictionTopology.<init>(RestrictionTopology.java:64)
        at com.graphhopper.reader.osm.RestrictionTopology.way(RestrictionTopology.java:59)
        at com.graphhopper.reader.osm.OSMRestrictionConverter.buildRestrictionTopologyForGraph(OSMRestrictionConverter.java:95)
        at com.graphhopper.reader.osm.OSMReader.addRestrictionsToGraph(OSMReader.java:616)
        at com.graphhopper.reader.osm.OSMReader.readGraph(OSMReader.java:180)
        at com.graphhopper.GraphHopper.importOSM(GraphHopper.java:933)
        at com.graphhopper.GraphHopper.process(GraphHopper.java:823)
        at com.graphhopper.GraphHopper.importAndClose(GraphHopper.java:787)
        at com.graphhopper.application.cli.ImportCommand.run(ImportCommand.java:36)
        at com.graphhopper.application.cli.ImportCommand.run(ImportCommand.java:27)
        at io.dropwizard.core.cli.ConfiguredCommand.run(ConfiguredCommand.java:98)
        at io.dropwizard.core.cli.Cli.run(Cli.java:78)
        at io.dropwizard.core.Application.run(Application.java:94)
        at com.graphhopper.application.GraphHopperApplication.main(GraphHopperApplication.java:38)

I have imported the planet before with 9.1, but this import is using 10.0 and I also added the following to my config:

weighting: custom
     turn_costs:
      vehicle_types: [motorcar, motor_vehicle]
      u_turn_costs: 60
     custom_model_files: [car.json]

Do you see any issues that could be causing this error? This was after about 30 hours of importing.

easbar · January 17, 2025, 5:12pm

This was fixed for the master branch, but the fix is not included in 9.1 or 10.0:

github.com/graphhopper/graphhopper

Handle via-way restrictions with multiple from/to ways correctly (no_entry/no_exit)

graphhopper:master ← graphhopper:via_way_restriction_multiple_from

opened 05:42PM - 03 Jan 25 UTC

easbar

+153 -21

Fixes #3086. The exception was caused by an extremely rare type of restrictio…n: a via-way restriction with multiple from-ways (restriction=no_entry). The following overpass query finds such restrictions: ``` relation[type=restriction](if:count_by_role("from") > 1); foreach -> .r ( way(r.r:via); if (count(ways) > 0) { .r out geom; } ); ``` Currently there are 54. But they are all invalid for various reasons like missing from/to-members, disconnected member ways etc. so we ignore them anyway. There is only one exception, namely [the one that has been added only recently and caused the error](https://www.openstreetmap.org/relation/18382917). That one isn't strictly necessary, because the desired turn restrictions could be represented with a simpler mapping, but it is 'correct' tagging nonetheless. Sidenote: This specific restriction is also time-dependent, so it will typically be ignored. Still, I somewhat see how this type of mapping can be useful and since we already had everything required in place I did not simply ignore these via-way no_entry/no_exit restrictions but added support for them.

So currently there are the following possible solutions for this:

build from source using the master branch
disabling turn costs (probably not what you want)
modifying the OSM file to exclude the turn restriction that causes the error

We might backport the fix and create version 10.1.

mrcachly · January 17, 2025, 5:41pm

Thanks! I will build from source and see how that works.

easbar · January 20, 2025, 9:01am

The problem should be fixed with GraphHopper 10.2