Busway Support

Connor_Riley · May 21, 2025, 6:35am

If I make a bus profile, how can I get the bus to use the busway tagged highways? For example, this one Way: ‪Bus Lane‬ (‪1134794367‬) | OpenStreetMap

From what I can see reading the code, it doesn’t seem like road_class supports busway at the moment?

github.com/graphhopper/graphhopper

core/src/main/java/com/graphhopper/routing/ev/RoadClass.java

f2e5ab57c


      
          
          /**
           * This enum defines the road class of an edge. It is heavily influenced from the highway tag in OSM that can be
           * primary, cycleway etc. All edges that do not fit get OTHER as value.
           */
          public enum RoadClass {
              OTHER, MOTORWAY, TRUNK, PRIMARY, SECONDARY, TERTIARY, RESIDENTIAL, UNCLASSIFIED,
              SERVICE, ROAD, TRACK, BRIDLEWAY, STEPS, CYCLEWAY, PATH, LIVING_STREET, FOOTWAY,
              PEDESTRIAN, PLATFORM, CORRIDOR, CONSTRUCTION;
          
              public static final String KEY = "road_class";
          
              public static EnumEncodedValue<RoadClass> create() {
                  return new EnumEncodedValue<>(RoadClass.KEY, RoadClass.class);
              }
          
              @Override
              public String toString() {
                  return Helper.toLowerCase(super.toString());
              }

easbar · May 21, 2025, 7:14am

Yes, but you could add it of course. You’ll also need to add it to CarAccessParser.java if you like to use car_access for your bus profile.

karussell · May 21, 2025, 7:16am

Currently the recommended way for bus support is to use bus_access (which uses the ModeAccessParser). See bus access by karussell · Pull Request #2913 · graphhopper/graphhopper · GitHub

Connor_Riley · May 27, 2025, 10:44pm

in the PR you made @karussell does that ingest ways that have the busway tag? If I want the bus to use ways tagged with busway, do I need to edit to the code as @easbar suggested?

Connor_Riley · May 27, 2025, 11:19pm

if I want to add the busway tag, but I don’t want to allow the default car profile to route on busways, can I accomplish this without adding to CarAccessParser? If I don’t add to that, but add the tag into the bus profile like this

    { "if": "bus_access && (road_class == BUSWAY || road_class == MOTORWAY || road_class == TRUNK || road_class == PRIMARY || road_class == SECONDARY || road_class == TERTIARY || road_class == UNCLASSIFIED || road_class == LIVING_STREET || road_class == RESIDENTIAL || road_class == SERVICE || road_class == ROAD)",
      "multiply_by": "1"
    },

will that work?

Connor_Riley · May 28, 2025, 1:29pm

I made a PR which seems to work. I’m not totally sure where I should write unit tests / how to unit test this – I’m assuming I need a unit test for the bus profile and one for the car profile, and I need to make sure the routing works correctly for each profile. Is there a code pointer for an example unit test I can pattern match?

github.com/graphhopper/graphhopper

adding busway support

master ← mobility-solutions-inc:ctriley/busway

opened 01:26PM - 28 May 25 UTC

ctriley

+13 -2

I'm not sure how to write a unit test for this -- hoping someone might advise me… on that. I tested manually on the graphhopper server with a lane that is marked as a busway using both the car profile and the bus profile. The car profile takes the road correctly, and the bus profile takes the bus lane. ![image](https://github.com/user-attachments/assets/97737093-baaf-419a-9704-33ef1bd6df49) ![image](https://github.com/user-attachments/assets/95c2546d-864e-42cd-8e83-8a855ec7c845) Please read [our contributing guide](https://github.com/graphhopper/graphhopper/blob/master/CONTRIBUTING.md) and note that also your contribution falls under the Apache License 2.0 as outlined there. Your first contribution should include a change where you add yourself to the CONTRIBUTORS.md file.