The unit tests Bike2WeightFlagEncoderTest and BikeFlagEncoderTest have to be adjusted. I’am not sure this is desired.
The tests fail if: highway=footpath and highway = path if bicycle=yes is set.
Currently, highway = footpath | path and bicycle = designated | official use the speed on bike paths.
IHMO this can be done by bicycle=yes as well.
When looking through the method, I also noticed that under certain circumstances the speed resulting from the surface is overwritten by the speed on bike paths.
Unfortunately at the moment I have not the time to go deeper in this
I would include in unit tests the case
highway = footpath | path
bicycle = designated yes |
surface = *
I am also considering smoothness. It would be nice if the visibility of getSpeed() were protected.
Thank you very much.