Bike Profil - highway=pathPath and bicycle=yes should not get speed for pushing section

rtrier · February 4, 2020, 9:08am

Hello,
in BikeCommonFlagEncode.getSpeed() check for condition where to increase the speed of pushing sections.
The check should include bicycle=yes
see: https://wiki.openstreetmap.org/wiki/DE:Key:bicycle

Thanks

karussell · February 4, 2020, 10:08am

Thanks!

Do you have a unit test to reproduce this issue and even better a fix ?

rtrier · February 4, 2020, 10:36am

I’ll try to find out why this looks like this (should not go to the beach)
https://graphhopper.com/maps/?point=54.441672%2C12.646208&point=54.447037%2C12.621961&locale=de&vehicle=bike&weighting=fastest&elevation=true&turn_costs=false&use_miles=false&layer=Omniscale

OSM:

It’s seems not only be a Problem with BikeCommonFlagEncode.getSpeed().

If I know what’s really happens I let you know and provide a fix, if I can.

Ralf

rtrier · February 5, 2020, 9:20am

Hi,
I made a pull request:

Ralf

rtrier · February 6, 2020, 10:11am

The unit tests Bike2WeightFlagEncoderTest and BikeFlagEncoderTest have to be adjusted. I’am not sure this is desired.

The tests fail if: highway=footpath and highway = path if bicycle=yes is set.

Currently, highway = footpath | path and bicycle = designated | official use the speed on bike paths.
IHMO this can be done by bicycle=yes as well.

When looking through the method, I also noticed that under certain circumstances the speed resulting from the surface is overwritten by the speed on bike paths.

Unfortunately at the moment I have not the time to go deeper in this

I would include in unit tests the case
highway = footpath | path
bicycle = designated yes |
surface = *

I am also considering smoothness. It would be nice if the visibility of getSpeed() were protected.

Thank you very much.

rtrier · February 6, 2020, 1:10pm

@karussell @ratrun
In the Unit-Tests Bike2WeightFlagEncoderTest and BikeFlagEncoderTest are checking the results of the method getSpeed() depending on the tags.

Someone has to decide which speed should be choosen for highway=footpath and bicycle=yes.
Then the test can be extended and the Method getSpeed() adjusted.
Any opinions to that?

Moreover it should be checked if there are tag combinations missing in the tests.

I had also the idea to inspect the osm data for Mecklenburg-Vorpommern and collect all used tag combinations in (relation to bikes). I have no idea how many this might be.

ratrun · February 6, 2020, 6:26pm

I believe that the speed should return the speed of the surface in case of segregated=yes in this case, otherwise something a litte bit below the cycleway speed. I’m going to have a look on it and prepare a pull request.