Racingbike vs. bike

Can you again review the branch? I just pushed some minor changes.

Done. I cross checked the tests against my modifications and every change I detected was an improvement :+1:.

Can you please create a PR now? I will do a formal review of the code changes on github then.

For now I would keep it at 4 bits. The better approach for the parsers would be to move them into a custom model to avoid this limitation at all but let them us simplify first :slight_smile:

Great, sounds like a plan!

Also should we increase from 20 to 24km/h? If yes, let’s do this in a separate PR afterwards.

Yes, we should increase it in a separate PR, independent of the bit size change for speed.

1 Like

Thanks! Have done so: Improve bike speed handling by karussell · Pull Request #3214 · graphhopper/graphhopper · GitHub