No path details unless calcPoints or calcInstructions is enabled

easbar · December 19, 2020, 9:58am

Why are path details disabled when calcPoints and calcInstructions are disabled?

graphhopper/graphhopper/blob/bde99a8ccd143f3852b3bc87b3bcb8b5328f8f0f/core/src/main/java/com/graphhopper/util/PathMerger.java#L127-L140


if (calcPoints || enableInstructions) {
    PointList tmpPoints = path.calcPoints();
    if (fullPoints.isEmpty())
        fullPoints = new PointList(tmpPoints.size(), tmpPoints.is3D());
    // Remove duplicated points, see #1138
    if (pathIndex + 1 < paths.size()) {
        tmpPoints.removeLastPoint();
    }
    fullPoints.add(tmpPoints);
    responsePath.addPathDetails(PathDetailsFromEdges.calcDetails(path, evLookup, weighting, requestedPathDetails, pathBuilderFactory, origPoints));
    origPoints = fullPoints.size();
}

karussell · December 19, 2020, 11:37am

Good question

I think there could be two bugs: enableInstructions should be removed completely and path details calculation should be moved outside.

easbar · December 19, 2020, 12:26pm

–> https://github.com/graphhopper/graphhopper/issues/2217