I am trying to make a new fix to the bug #329 break not inserted while it should, by following Stefan’s suggestion:
It might never fail to schedule a break if one started with scheduling a break in an empty route.
as it seems more efficient than my previous fix #332.
It will require allowing break to be inserted into an empty route. However, this is explicitly disallowed in the current BreakInsertionCalculator by this line:
if (currentRoute.isEmpty()) return InsertionData.createEmptyInsertionData();
Thus, I am wondering if there is any potential issue with allowing break to be inserted into an empty route? If there is no potential issue, I guess I can just go ahead and remove the aforementioned line.